Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing gcovr usage for -p and -d flags #122

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Conversation

LeStarch
Copy link
Collaborator

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Changes gcov handling:

  1. Improves autocoding to allow including via flags: --all-ac, --comp-ac, --port-ac, --type-ac to include each of the types of Ac
  2. Removes the special ac directory called {{AUTOCODE}}. Modern gcovr doesn't support it and it was a maintenance nightmare
  3. Fixed handling of -d and -p flags

@LeStarch LeStarch requested a review from thomas-bc March 29, 2023 23:13
Copy link
Contributor

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of comments but this looks good!

src/fprime/fbuild/gcovr.py Outdated Show resolved Hide resolved
src/fprime/util/build_helper.py Outdated Show resolved Hide resolved
src/fprime/fbuild/target.py Outdated Show resolved Hide resolved
@LeStarch
Copy link
Collaborator Author

Ready for re-review.

@LeStarch LeStarch merged commit 9e01914 into nasa:devel Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants