-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Deployment generation feature #123
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeStarch
requested changes
Apr 4, 2023
...deployment/{{cookiecutter.deployment_name}}/Top/{{cookiecutter.deployment_name}}Topology.hpp
Outdated
Show resolved
Hide resolved
...oyment/{{cookiecutter.deployment_name}}/Top/{{cookiecutter.deployment_name}}TopologyDefs.hpp
Outdated
Show resolved
Hide resolved
...utter_templates/cookiecutter-fprime-deployment/{{cookiecutter.deployment_name}}/settings.ini
Show resolved
Hide resolved
Some minor change requests, otherwise this refactor looks really nice! |
Two other comments:
|
I addressed your comments, ready for re-review |
LeStarch
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I very much relate to your last 4 commits.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fprime-util new
Change Description
new --deployment
utility_entry()
to cli.py because it was odd in build_helper.pyutility_entry()
calls only if it needs tonew
target to generate is now an argparse mutually_exclusive_group so we can defer that logic to argparse instead of handling itRationale
Addresses nasa/fprime#1926. Will be used for short tutorials and workshops. Has been requested for a long time. The created deployment contains the basic CNDH stack so that users can get started easily.
Request for comments
The cookiecutter stuff is in
fbuild/interaction.py
which is a little odd hierarchy/naming. I was thinking of putting thenew_***
functions in a new module underutil/
but that would make yet more refactoring. Let me know if you think that's good or if you see issues with that and I'll put it in for the futurenew --project
feature.Future Work
TODO: loadParameter() has been commented out in the generated
configureTopology()
because the function is not autocoded yet. A fix will likely be made where the function gets autocoded even if not parameters are used. Should be un-commented then.We could add the following cookiecutter options: