New Component (FPP) generation feature #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
LeStarch
requested changes
Apr 14, 2023
...iecutter_templates/cookiecutter-fprime-component/{{cookiecutter.component_name}}/docs/sdd.md
Show resolved
Hide resolved
| def add_to_cmake(list_file: Path, comp_path: Path): | ||
| """Adds new component or port to CMakeLists.txt""" | ||
| print(f"[INFO] Found CMakeLists.txt at '{list_file}'") | ||
| def add_to_cmake(list_file: Path, comp_path: Path, project_root: Path = None): |
There was a problem hiding this comment.
This function doesn't look like it will work with arbitrary CMake structure.
e.g. it only works with the parent cmake list, not project.cmake nor if there are empty directories in between.
In other implementations of this we have recursed upward to project root looking for:
- If
project.cmakethen add to it - Else if
CMakeLists.txtthen add to it - Else, repeat on parent directory
There was a problem hiding this comment.
Added my take at implementing this, let me know how that looks
LeStarch
approved these changes
Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fprime-util newChange Description
fprime-util new --componentchanged to generate FPP instead of XML.Future work
Ports are much much easier to create in FPP than in XML and probably do not require a
new --portfunctionality. Should we get rid of it? Michael you mentioned anew --moduleidea instead.