Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor new build system structure (nasa#1994) #142

Merged
merged 6 commits into from
May 30, 2023

Conversation

thomas-bc
Copy link
Contributor

@thomas-bc thomas-bc commented May 30, 2023

Originating Project/Creator
Affected Architectures(s) fprime-util new
Related Issue(s) nasa/fprime#1994 nasa/fprime#2002

Change Description

Addresses nasa/fprime#2002

nasa/fprime#1994 introduced a new structure for projects where the CMake project() can be defined at the top level of the project tree only, and not within deployments. This modifies the fprime-util new commands to account for that.

I also took the liberty to add the Components/ module to the project generation tree because it sounds to me like a good pattern to suggest to users - while it does not force anything onto them.

Note: I had to revert back the default fprime version new --project pulls since #1994 is only in devel for now.

Testing/Review Recommendations

Checkout, install, and verify that fprime-util new --project && fprime-util new --deployment generates a buildable and runnable project.

Future Work

  • Switch default project F´ version back to master for next release.
  • Somewhat unrelated, fprime-gds should automatically detect the deployment's build-artifacts/ when ran within the deployment module. Currently, we need to pass in -d ../build-artifacts/MyDeployment or run at the top level of the project tree.

@thomas-bc thomas-bc requested a review from LeStarch May 30, 2023 18:51
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor questions, otherwise looks good!

@thomas-bc thomas-bc merged commit 49f4e70 into nasa:devel May 30, 2023
28 checks passed
@thomas-bc thomas-bc deleted the new-deployment-1994 branch October 11, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants