-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor new
build system structure (nasa#1994)
#142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeStarch
reviewed
May 30, 2023
src/fprime/cookiecutter_templates/cookiecutter-fprime-project/cookiecutter.json
Outdated
Show resolved
Hide resolved
LeStarch
reviewed
May 30, 2023
src/fprime/cookiecutter_templates/cookiecutter-fprime-project/hooks/post_gen_project.py
Outdated
Show resolved
Hide resolved
LeStarch
reviewed
May 30, 2023
...okiecutter_templates/cookiecutter-fprime-project/{{cookiecutter.project_name}}/project.cmake
Show resolved
Hide resolved
LeStarch
reviewed
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor questions, otherwise looks good!
LeStarch
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fprime-util new
Change Description
Addresses nasa/fprime#2002
nasa/fprime#1994 introduced a new structure for projects where the CMake project() can be defined at the top level of the project tree only, and not within deployments. This modifies the
fprime-util new
commands to account for that.I also took the liberty to add the
Components/
module to the project generation tree because it sounds to me like a good pattern to suggest to users - while it does not force anything onto them.Note: I had to revert back the default fprime version
new --project
pulls since #1994 is only in devel for now.Testing/Review Recommendations
Checkout, install, and verify that
fprime-util new --project && fprime-util new --deployment
generates a buildable and runnable project.Future Work
fprime-gds
should automatically detect the deployment'sbuild-artifacts/
when ran within the deployment module. Currently, we need to pass in-d ../build-artifacts/MyDeployment
or run at the top level of the project tree.