Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: FPP Visualize #147

Merged
merged 15 commits into from
Aug 1, 2023
Merged

Feature: FPP Visualize #147

merged 15 commits into from
Aug 1, 2023

Conversation

thomas-bc
Copy link
Contributor

@thomas-bc thomas-bc commented Jun 16, 2023

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s) nasa/fprime#2059
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Depends on:

Introducing: fprime-util visualize
Within a Topology directory, performs the following

  • fpp-to-xml
  • fpl-convert-xml
  • fpl-layout
  • start fprime-visual Flask app to serve visualization

Effectively, this allows with a single command to spin up a visualization of the topology and all its subtopology graphs.

cd Ref/Top
fprime-util visualize

Rationale

Major QoL improvement to visualization capabilities. This is currently doable, but requires a lot of manual installation of tools etc...

Todo

  • The 2 things listed in Depends on
  • Probably add some tests

Note

Opening as draft in case there's change requests. Do not merge for now, there are a couple of dependencies for this that need to be released before this can go through.

@thomas-bc thomas-bc requested a review from LeStarch June 16, 2023 03:48
@thomas-bc
Copy link
Contributor Author

Fails tests because fprime_visual pip package is not currently published.

src/fprime/fpp/visualize.py Outdated Show resolved Hide resolved
src/fprime/fpp/visualize.py Outdated Show resolved Hide resolved
@thomas-bc thomas-bc marked this pull request as ready for review July 5, 2023 23:59
@thomas-bc
Copy link
Contributor Author

Ready for review, as all the pieces are there, see nasa/fprime#2059 (comment)

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions, but looks generally good.

src/fprime/fpp/cli.py Outdated Show resolved Hide resolved
src/fprime/fpp/cli.py Show resolved Hide resolved
src/fprime/fpp/visualize.py Outdated Show resolved Hide resolved
LeStarch
LeStarch previously approved these changes Jul 11, 2023
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one more minor question, but not sure it should trip up the PR.

@thomas-bc thomas-bc merged commit 2c88b8b into nasa:devel Aug 1, 2023
28 checks passed
@thomas-bc thomas-bc deleted the feat/fpp-visualize branch October 11, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants