Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate for new build structure #154

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Conversation

thomas-bc
Copy link
Contributor

@thomas-bc thomas-bc commented Jul 25, 2023

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s) nasa/fprime#2094
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Making sure we're still relevant for the new build structure introduced by nasa/fprime#1994
Correcting "assumptions" in the code that deployment==cmake project, which mostly came down to variable names and vocabulary.
I had to scrub a minor thing in new --component that would use the deployment's name as default prompt for component namespace, if the command is ran from a deployment. I thought about switching to using CWD's name, since that's usually what I've seen being used.

Testing/Review Recommendations

I tested as much as I could with projects on the old and new build structure, as well as with core fprime.

@thomas-bc thomas-bc requested a review from LeStarch July 25, 2023 01:12
@LeStarch
Copy link
Collaborator

"I thought about switching to using CWD's name, since that's usually what I've seen being used." Yes! Do this!

LeStarch
LeStarch previously approved these changes Jul 25, 2023
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/fprime/fbuild/builder.py Show resolved Hide resolved
@thomas-bc thomas-bc merged commit 9cd5373 into nasa:devel Jul 26, 2023
28 checks passed
@thomas-bc thomas-bc deleted the update/issue-2094 branch October 11, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants