Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run FppUtility in cwd=context #180

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Run FppUtility in cwd=context #180

merged 2 commits into from
Nov 28, 2023

Conversation

thomas-bc
Copy link
Contributor

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Running FppUtility.execute() in cwd=context.
Necessary because fpp-to-cpp will output relative include paths based on CWD at runtime

Future Work

Consider whether this behavior from fpp-to-cpp should be reworked.

LeStarch
LeStarch previously approved these changes Nov 28, 2023
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct!

@LeStarch LeStarch merged commit 12fcefe into nasa:devel Nov 28, 2023
24 checks passed
@thomas-bc thomas-bc deleted the fpp-cwd branch November 28, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants