Add Ninja support #188
Merged
Add Ninja support #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeStarch
reviewed
Jan 11, 2024
| # CMake 3.12+ supports parallel builds with -j | ||
| jobs = make_args.pop("--jobs", None) | ||
| if jobs is not None: | ||
| run_args.extend(["-j", str(jobs)]) |
There was a problem hiding this comment.
Note: try to not specify the -j flag when building without it.
LeStarch
requested changes
Jan 11, 2024
LeStarch
approved these changes
Jan 11, 2024
LeStarch
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Add support for using the Ninja CMake Generator. Turns out not a lot of things needed changing, for one main reason: Ninja refreshes the build cache automatically when it detects changes or a missing target.
fprime-util generate --ninjagenerates a build cache using Ninja.Testing/Review Recommendations
Beta release? I tested manually as much as I could, but I'm sure there's going to be edge cases.