Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MarkupSafe==2.0.1 to install_requires #49

Merged

Conversation

capsulecorplab
Copy link
Contributor

@capsulecorplab capsulecorplab commented Mar 30, 2022

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

add "MarkupSafe==2.0.1" to install_requires in setup.py

Rationale

Fixes #48

Testing/Review Recommendations

  • pip install fprime-tools
  • Check MarkupSafe version by running pip freeze | grep MarkupSafe
  • If MarkupSafe version is 2.1.1, fprime-util --help may throw an error
  • Clone & cd into fprime-tools repo and checkout commit 23c25be
  • Reinstall fprime-tools with python setup.py install
  • Rerun fprime-util --help

@Joshua-Anderson
Copy link
Contributor

Has this error with newer versions of MarkupSafe been fixed in Jinja yet? It might be possible to just update cookiecutter, which could upgrade jinja to support the new version of MarkupSafe.

@LeStarch LeStarch closed this Apr 26, 2022
@LeStarch LeStarch reopened this Apr 26, 2022
@LeStarch
Copy link
Collaborator

I am seeing a conflict here: cookiecutter needs < 2.0.0 and this has marked specifically 2.0.1

@capsulecorplab capsulecorplab force-pushed the bug/importerror-with-markupsafe/48 branch from f448e43 to f85f37e Compare April 29, 2022 18:30
@capsulecorplab
Copy link
Contributor Author

Changed MarkupSafe==2.0.1 to MarkupSafe<2.0.0 in install_requires list in setup.py

@LeStarch LeStarch merged commit 152a37e into nasa:devel May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError with MarkupSafe version 2.1.1
3 participants