Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace conditional assignment to a variable with an if expression #68

Merged
merged 1 commit into from
May 23, 2022
Merged

Replace conditional assignment to a variable with an if expression #68

merged 1 commit into from
May 23, 2022

Conversation

ThibFrgsGmz
Copy link
Contributor

Originating Project/Creator @ThibFrgsGmz
Affected Component serialize module
Affected Architectures(s) serializer
Related Issue(s) (void)
Has Unit Tests (y/n) n
Builds Without Errors (y/n) y
Unit Tests Pass (y/n) n
Documentation Included (y/n) n

Change Description

This PR aims to replace two conditional assignments to a variable by if expressions.

Rationale

The ternary operator is represented by the conditional expression syntax of Python. This is a significant improvement in the case where the conditional expression is :

  • short and can be written on a single line

  • not difficult (no nested expressions or long boolean strings).

Testing/Review Recommendations

(void)

Future Work

(void)

@LeStarch LeStarch merged commit b741779 into nasa:devel May 23, 2022
@ThibFrgsGmz ThibFrgsGmz deleted the feat/assign-if-exp branch July 20, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants