Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a single value to the dictionary directly rather than using update() #69

Merged
merged 1 commit into from
May 23, 2022
Merged

Add a single value to the dictionary directly rather than using update() #69

merged 1 commit into from
May 23, 2022

Conversation

ThibFrgsGmz
Copy link
Contributor

Originating Project/Creator @ThibFrgsGmz
Affected Component fbuild
Affected Architectures(s) none
Related Issue(s) (void)
Has Unit Tests (y/n) n
Builds Without Errors (y/n) y
Unit Tests Pass (y/n) n
Documentation Included (y/n) n

Change Description

This PR aims to change the way to add a single value to the dictionary by doing it directly rather than using update() when possible.

Rationale

It is easier to add an entry to a dictionary directly rather than using the update() method. It also removes the overhead of creating another dictionary and calling a method, which should improve performance slightly.

Testing/Review Recommendations

(void)

Future Work

(void)

@LeStarch LeStarch merged commit fda3302 into nasa:devel May 23, 2022
@ThibFrgsGmz ThibFrgsGmz deleted the feat/simplify-dictionary-update branch July 20, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants