Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target.get_target refactored by converting a for loop into a list comprehension #72

Merged
merged 1 commit into from
May 23, 2022
Merged

Target.get_target refactored by converting a for loop into a list comprehension #72

merged 1 commit into from
May 23, 2022

Conversation

ThibFrgsGmz
Copy link
Contributor

Originating Project/Creator @ThibFrgsGmz
Affected Component fbuild/target get_target()
Affected Architectures(s) (void)
Related Issue(s) (void)
Has Unit Tests (y/n) n
Builds Without Errors (y/n) Let CI run
Unit Tests Pass (y/n) Let CI run
Documentation Included (y/n) n

Change Description

This PR aims to refactor Target.get_target by converting a for loop into a list comprehension.

Rationale

Comprehensions generally run faster than building the collection in a loop, thus improving performance. It also improves the readability of the code.

Testing/Review Recommendations

(void)

Future Work

(void)

@LeStarch LeStarch merged commit 9c3947e into nasa:devel May 23, 2022
@ThibFrgsGmz ThibFrgsGmz deleted the feat/list-comprehension-get-target branch July 20, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants