Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unnecessary comprehension with a generator #80

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Replace unnecessary comprehension with a generator #80

merged 1 commit into from
Jun 6, 2022

Conversation

ThibFrgsGmz
Copy link
Contributor

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s) void
Has Unit Tests (y/n) n
Builds Without Errors (y/n) Let CI run
Unit Tests Pass (y/n) Let CI run
Documentation Included (y/n) n

Change Description

This PR aims to replace unneeded comprehension with generator.

Rationale

Functions like sum allow a generator to be passed rather than a collection.
By doing so, you remove a pair of parentheses, which makes the intent slightly clearer.
Also, the function will immediately return an item if it finds one, rather than having to construct the entire list.
This lazy evaluation can lead to performance improvements.

Testing/Review Recommendations

void

Future Work

void

@LeStarch LeStarch merged commit 2aa21a1 into nasa:devel Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants