Replace unnecessary comprehension with a generator #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This PR aims to replace unneeded comprehension with generator.
Rationale
Functions like
sum
allow a generator to be passed rather than a collection.By doing so, you remove a pair of parentheses, which makes the intent slightly clearer.
Also, the function will immediately return an
item
if it finds one, rather than having to construct the entire list.This lazy evaluation can lead to performance improvements.
Testing/Review Recommendations
void
Future Work
void