Inline variables returned immediately #82
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The goal of this PR is to inline some variables to a
return
in case the declared variable is immediately returned.Rationale
Intermediate variables can be useful if they are used later as a parameter or condition, and their name can provide context for what the variable represents.
If returned by a function, the function name is present to indicate the type of result.
I took the liberty of removing these intermediate variables because they don't really add value.
Returning the result directly reduces the mental load of reading the function by shortening the code and removing an unnecessary variable.
Testing/Review Recommendations
void
Future Work
void