Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit inheritance of object class in HelpText class #89

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Remove explicit inheritance of object class in HelpText class #89

merged 1 commit into from
Jun 24, 2022

Conversation

ThibFrgsGmz
Copy link
Contributor

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s) void
Has Unit Tests (y/n) n
Builds Without Errors (y/n) Let CI run
Unit Tests Pass (y/n) Let CI run
Documentation Included (y/n) n

Change Description

The purpose of this PR is to remove the explicit inheritance of the HelpText class from the object class.

Rationale

In Python 3, the inheritance of the object class is implicit, and can therefore be safely removed from the bases. ref

Testing/Review Recommendations

void

Future Work

void

@LeStarch LeStarch self-requested a review June 16, 2022 22:25
@LeStarch
Copy link
Collaborator

Code change looks good. Not sure why this one matters. Is it more Pythonic to omit this?

@ThibFrgsGmz
Copy link
Contributor Author

That's it, since Python 3 it would be useless to mention it.

@LeStarch LeStarch closed this Jun 23, 2022
@LeStarch LeStarch reopened this Jun 23, 2022
@LeStarch LeStarch merged commit a801bda into nasa:devel Jun 24, 2022
@ThibFrgsGmz ThibFrgsGmz deleted the feat/rm-useless-inherit-obj branch July 20, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants