Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify if expression by using or #93

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Simplify if expression by using or #93

merged 1 commit into from
Jul 13, 2022

Conversation

ThibFrgsGmz
Copy link
Contributor

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s) void
Has Unit Tests (y/n) n
Builds Without Errors (y/n) Let CI run
Unit Tests Pass (y/n) Let CI run
Documentation Included (y/n) n

Change Description

The purpose of this PR is to replace one if expression that compares to a target with or.

Rationale

We end up setting a value if it is True, and otherwise using a default value.

The version with or is a little easier to read and avoids duplicating path_list.

It works because the left side is evaluated first. If it is evaluated to True, value will be set to path_list and the right side will not be evaluated.
If the result is False, the right side will be evaluated and the value will be set as the default.

Testing/Review Recommendations

void

Future Work

void

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@LeStarch LeStarch merged commit 66eb807 into nasa:devel Jul 13, 2022
@ThibFrgsGmz ThibFrgsGmz deleted the feat/or_if_exp_ident branch July 20, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants