Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lestarch: fixing incorrectly named setting #94

Merged
merged 3 commits into from
Jul 21, 2022
Merged

lestarch: fixing incorrectly named setting #94

merged 3 commits into from
Jul 21, 2022

Conversation

LeStarch
Copy link
Collaborator

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Fix an incorrectly named setting causing F´ to improperly load config directories.

@LeStarch
Copy link
Collaborator Author

Tested this. Both revised settings properly toggle the expected cmake variable.

@LeStarch LeStarch force-pushed the update/incorrectly-renamed-setting branch 2 times, most recently from 467c94c to 10b784e Compare July 20, 2022 21:28
@LeStarch LeStarch force-pushed the update/incorrectly-renamed-setting branch from 10b784e to c89a038 Compare July 20, 2022 22:07
@LeStarch
Copy link
Collaborator Author

Note: this PR also renames install_dest -> install_destination for consistency, as some fields use abbreviations and others did not.

kevin-f-ortega
kevin-f-ortega approved these changes Jul 21, 2022
View reviewed changes
Copy link

@kevin-f-ortega kevin-f-ortega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kevin-f-ortega kevin-f-ortega merged commit 2ba8103 into nasa:devel Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-f-ortega kevin-f-ortega kevin-f-ortega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LeStarch @kevin-f-ortega