Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clickable Assert Messages (FSW) #1847

Closed
LeStarch opened this issue Jan 16, 2023 · 5 comments
Closed

Clickable Assert Messages (FSW) #1847

LeStarch opened this issue Jan 16, 2023 · 5 comments
Assignees
@LeStarch
Labels
enhancement

Comments

@LeStarch
Copy link
Collaborator

LeStarch commented Jan 16, 2023 •
edited

F´ Version
Affected Component

Feature Description

Make FW_ASSERT messages clickable (e.g. <file>:<line>).

Rationale

This worked well for UT asserts.
@LeStarch
Copy link
Collaborator Author

We are still discussing this, it is not ready for implementation.

@LeStarch LeStarch mentioned this issue Jan 16, 2023
Closed
@LeStarch
Copy link
Collaborator Author

LeStarch commented Mar 1, 2023

This has been approved! We can implement!

@SMorettini
Copy link
Contributor

I would be happy to implement it :)

@LeStarch LeStarch self-assigned this May 3, 2023
@LeStarch
Copy link
Collaborator Author

@SMorettini did you still want to look into implementing this?

@LeStarch LeStarch removed the question label May 10, 2023
SMorettini pushed a commit to SMorettini/fprime that referenced this issue May 13, 2023
Made assert clickable (nasa#1847)
c15b89b
@SMorettini SMorettini mentioned this issue May 13, 2023
Merged
@SMorettini
Copy link
Contributor

Just created a pull request to implement it.

LeStarch pushed a commit that referenced this issue May 24, 2023
@SMorettini
Made assert clickable (#1847) (#2022)
f5b34f2 
* Made assert clickable (#1847)

* Update asserts with file id

---------

Co-authored-by: Simone Morettini <s.morettini.cs@gmail.com>
@LeStarch LeStarch closed this as completed Jun 1, 2023
sobkulir pushed a commit to sobkulir/fprime that referenced this issue Jun 15, 2023
@SMorettini @sobkulir
Made assert clickable (nasa#1847) (nasa#2022)
71c61f9 
* Made assert clickable (nasa#1847)

* Update asserts with file id

---------

Co-authored-by: Simone Morettini <s.morettini.cs@gmail.com>
Boehm-Michael pushed a commit to Boehm-Michael/fprime that referenced this issue Jun 22, 2023
@SMorettini @Boehm-Michael
Made assert clickable (nasa#1847) (nasa#2022)
a2ea39e 
* Made assert clickable (nasa#1847)

* Update asserts with file id

---------

Co-authored-by: Simone Morettini <s.morettini.cs@gmail.com>
thomas-bc pushed a commit that referenced this issue Aug 4, 2023
@SMorettini @thomas-bc
Made assert clickable (#1847) (#2022)
86f7598 
* Made assert clickable (#1847)

* Update asserts with file id

---------

Co-authored-by: Simone Morettini <s.morettini.cs@gmail.com>
thomas-bc added a commit that referenced this issue Aug 4, 2023
@thomas-bc
Revert "Made assert clickable (#1847) (#2022)"
a60a5c3 
This reverts commit 86f7598.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeStarch LeStarch

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LeStarch @SMorettini