Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Downlink PermissionError crashes the GDS #1970

Closed
gjwatney opened this issue Apr 19, 2023 · 2 comments
Closed

File Downlink PermissionError crashes the GDS #1970

gjwatney opened this issue Apr 19, 2023 · 2 comments
Assignees
Labels

Comments

@gjwatney
Copy link
Collaborator

F´ Version
Affected Component

Problem Description

If you donwnlink a file and it fails, for example due to permissions issues on the host, the GDS green dot will change to a red x and not recover.

How to Reproduce

  1. Have another user downlink a file so that /tmp/fprime-downlink is only writable by that user
  2. Attempt file downlink as a new user
  3. Observe red x in GDS window

Expected Behavior

Generate an EVR that reports the permission issue and keeps running
Can fprime-gds be configured to either (1) make its directories group writable by default or (2) use a user's home directory for downlink? Otherwise, we all need sudo to keep changing permissions depending on who is downlinking

@gjwatney gjwatney added the bug label Apr 19, 2023
@LeStarch
Copy link
Collaborator

The issue is that when the GDS encounters a permissions issue, it shouldn't just crash. It should recover and keep running.

@gjwatney gjwatney changed the title File Downlink problem crashes the flight software File Downlink PermissionError crashes the GDS May 5, 2023
@gjwatney
Copy link
Collaborator Author

gjwatney commented May 5, 2023

This is fixed in the following pull request
nasa/fprime-gds#128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants