Downlink files are placed in /tmp/<username>/fprime-downlink

[gjwatney]

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

---

Change Description

Downlinked files are placed in /tmp//fprime-downlink

Rationale

This fixes the problem described in nasa/fprime#1970

Testing/Review Recommendations

Let different users try and download files. The GDS should not throw a Permission Error

Future Work

Note any additional work that will be done relating to this issue.

[thomas-bc]

@gjwatney I'm not sure I understand the reason you're choosing /tmp/username here. Are you expecting the permissions to be different there than in /tmp ? I'm thinking this might be specific to your system.
As was mentioned in #1970 a good approach could be to handle the case where a permission error occurs and keep the process going instead of crashing.

[LeStarch]

The primary issue is if multiple users run on one shared GDS box, then their instances of the GDS will collide.

[LeStarch]

@thomas-bc for now I like this fix. We at some point should consider the following:

1. A better place to log: temp directory from "tempfile" package. This will work, but is hard to find. "logs/downlink" to keep it with the other gds logs.
2. Fix the permissions error in-case. However, fixing it here would not help the root issue as the file would not downlink.