Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDS Fails To Launch With Unknown Types In Dictionary #2230

Open
LeStarch opened this issue Aug 23, 2023 · 1 comment
Open

GDS Fails To Launch With Unknown Types In Dictionary #2230

LeStarch opened this issue Aug 23, 2023 · 1 comment
Labels
bug Easy First Issue An issue that should be straight forward to implement, and easily tested via CI. F´ GDS Issues pertaining to the F´ GDS help wanted High Priority High Priority issue that needs to be resolved.

Comments

@LeStarch
Copy link
Collaborator

F´ Version all

Problem Description

The GDS crashes on launch when provided with a dictionary containing references to a handcoded type. See: #1643 (comment)

This may also apply to other complicated types like serlizables.

Expected Behavior

Instead of failing to launch, the GDS should launch but warn that it's unable to deserialize EVRs referencing the handcoded type.

@LeStarch LeStarch added the bug label Aug 23, 2023
@LeStarch
Copy link
Collaborator Author

From: @JackNWhite

I am trying out this modification.

diff --git a/src/fprime_gds/common/loaders/xml_loader.py b/src/fprime_gds/common/loaders/xml_loader.py
index b7e8984..4cc0e0c 100644
--- a/src/fprime_gds/common/loaders/xml_loader.py
+++ b/src/fprime_gds/common/loaders/xml_loader.py
@@ -180,7 +180,13 @@ class XmlLoader(dict_loader.DictLoader):
 
                 arg_name = arg_dict[self.ARG_NAME_TAG]
                 arg_type_name = arg_dict[self.ARG_TYPE_TAG]
-                arg_typ_obj = self.parse_type(arg_type_name, arg, xml_tree, context)
+
+                try:
+                    arg_typ_obj = self.parse_type(arg_type_name, arg, xml_tree, context)
+
+                # Return nothing if the args are at least partly nonsense
+                except exceptions.GseControllerParsingException:
+                    return []
 
                 arg_desc = None
                 if self.ARG_DESC_TAG in arg_dict:

@thomas-bc thomas-bc added the F´ GDS Issues pertaining to the F´ GDS label Aug 24, 2023
@LeStarch LeStarch added High Priority High Priority issue that needs to be resolved. help wanted Easy First Issue An issue that should be straight forward to implement, and easily tested via CI. labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Easy First Issue An issue that should be straight forward to implement, and easily tested via CI. F´ GDS Issues pertaining to the F´ GDS help wanted High Priority High Priority issue that needs to be resolved.
Projects
None yet
Development

No branches or pull requests

2 participants