Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from C-style enum constructs for Os/Queue.hpp #1589

Merged
merged 1 commit into from Jul 25, 2022

Conversation

Anirban166
Copy link
Contributor

@Anirban166 Anirban166 commented Jul 23, 2022

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n) n
Builds Without Errors (y/n) y
Unit Tests Pass (y/n) y
Documentation Included (y/n) n

Change Description

Switch from the typedef enum { ... } enumName; construct to enum enumName { ... }; instead.

Rationale

typedef is not required when declaring enumerations in C++ to avoid the prepended use of the enum keyword when using the enum post-declaration.

Testing/Review Recommendations

Going with one file per PR!

Future Work

Making this minor change for similar typedef-aliased enum declarations in other files

@Anirban166 Anirban166 changed the title Switch away from C-style enum constructs Switch away from C-style enum constructs for Os/Queue.hpp Jul 23, 2022
@Anirban166 Anirban166 changed the title Switch away from C-style enum constructs for Os/Queue.hpp Migrate away from C-style enum constructs for Os/Queue.hpp Jul 23, 2022
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-CI Checks: Must perform before launching CI

  • No obviously malicious code introduced
  • PR is against devel. Use Edit -> change branch to fix, or close PR.

Code Review

  • Code follows flight software quality guidelines
  • Changes are of reasonable length for review

Procedural Checks

  • PR passes CI
  • Accept with squash-and-merge

@LeStarch LeStarch merged commit 5edd51b into nasa:devel Jul 25, 2022
@Anirban166 Anirban166 deleted the patch-1 branch July 30, 2022 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants