Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise proper exceptions in python generators #1660

Merged
merged 1 commit into from Sep 26, 2022

Conversation

redixin
Copy link
Contributor

@redixin redixin commented Sep 19, 2022

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Change exception classes to less broad. E.g. Exception -> NotImplementedError

Rationale

Raising and catching `Exception' directly is not recommended in python. There are plenty built in exceptions to be used instead.

Testing/Review Recommendations

Please refer to python2 docs

https://python.readthedocs.io/en/v2.7.2/library/exceptions.html

Future Work

Consider migrating to python3, as python2 EOL is already reached.

@LeStarch LeStarch changed the base branch from master to devel September 19, 2022 17:36
@LeStarch LeStarch closed this Sep 19, 2022
@LeStarch LeStarch reopened this Sep 19, 2022
@LeStarch
Copy link
Collaborator

Trying to force rerunning of checks that failed because devel was behind master.

@LeStarch LeStarch changed the base branch from devel to master September 20, 2022 18:06
@LeStarch LeStarch changed the base branch from master to devel September 20, 2022 18:07
@LeStarch LeStarch merged commit 604fcfc into nasa:devel Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants