Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parenthesis in conditions #1908

Merged
merged 1 commit into from Feb 26, 2023
Merged

Add parenthesis in conditions #1908

merged 1 commit into from Feb 26, 2023

Conversation

usamahz
Copy link
Contributor

@usamahz usamahz commented Feb 25, 2023

Originating Project/Creator fprime
Affected Component N/A
Affected Architectures(s) N/A
Related Issue(s) N/A
Has Unit Tests (y/n) n
Builds Without Errors (y/n) N/A
Unit Tests Pass (y/n) N/A
Documentation Included (y/n) n

Change Description

This PR adds the parenthesis in the if conditions in the following files:

Drv/TcpClient/test/ut/Tester.cpp
Drv/TcpServer/test/ut/Tester.cpp
Drv/Udp/test/ut/Tester.cpp

Rationale

Good not to depend on the operator precedence inside the conditional statements.

Testing/Review Recommendations

Check the relevant test passes.

Future Work

N/A

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Thanks for the change.

@LeStarch LeStarch merged commit ce6d5f8 into nasa:devel Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants