Make Framer.comStatusIn port sync, avoid mutual exclusion locking
#2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrosemurgy
changed the title
comStatusIn port sync, avoid mutual exclusion lockingFramer.comStatusIn port sync, avoid mutual exclusion locking
LeStarch
approved these changes
May 24, 2023
thomas-bc
approved these changes
May 25, 2023
Boehm-Michael
pushed a commit
to Boehm-Michael/fprime
that referenced
this pull request
Jun 22, 2023
thomas-bc
pushed a commit
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FramerChange Description
This change allows the
Framer.comStatusInport to be called synchronously. Previously, a deadlock situation occurred when routingdue to this port being
guarded.Verification
Tested with the topology above. Downlink worked as expected with F' GDS.