Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated HelloWorld tutorial to F' community #2095

Merged
merged 1 commit into from Jun 28, 2023
Merged

Conversation

hAkselS
Copy link
Contributor

@hAkselS hAkselS commented Jun 21, 2023

This PR removes the hello world tutorial from NASA/fprime repo and references the hello world on fprime-community in all NASA/fprime READMEs

Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something I realize just now is that by doing this (removing the entire folder), the https://nasa.github.io/fprime/Tutorials/HelloWorld/Tutorial.html link will die, however that's the link that's in master's README and there's not much we can do about this until next release.

@hAkselS
Copy link
Contributor Author

hAkselS commented Jun 21, 2023 via email

@thomas-bc
Copy link
Collaborator

The docs are built out of devel, so I expect the page would die immediately if we remove the folder from there.

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tutorial rework looks good to me. @thomas-bc ready for merge? If we break the README as shown on github.com, perhaps we can change that link in a dedicated PR? or we can move the "main branch" to devel since we have a tool that pulls the correct version down.

Also, we should probably rework that readme too....

@thomas-bc thomas-bc merged commit b3493ca into nasa:devel Jun 28, 2023
2 checks passed
thomas-bc added a commit that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants