Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sleep to avoid test failing because of execution too fast #2197

Merged
merged 1 commit into from Aug 23, 2023

Conversation

SMorettini
Copy link
Contributor

@SMorettini SMorettini commented Aug 16, 2023

Originating Project/Creator
Affected Component Svc.PassiveRateGroup

Change Description

I added a sleep of 1us to simulate some work when the port RateGroupMemberOut is called.

Rationale

The UT of PassiveRateGroup was, sometimes, failing on my laptop because the cycle_time of PassiveRateGroup::CycleIn_handler was smaller than 1 us(it was around 700ns).

The error I was having before the fix :

Fprime/Svc/PassiveRateGroup/test/ut/PassiveRateGroupImplTester.cpp:79: Failure
Expected: (this->tlmHistory_MaxCycleTime->at(0).arg) > (0), actual: 0 vs 0

@LeStarch LeStarch merged commit a2a7ada into nasa:devel Aug 23, 2023
24 checks passed
@SMorettini SMorettini deleted the fix-Passive-Rate-Group-UT branch August 24, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants