Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Two Minor CMake Bugs #2412

Merged
merged 2 commits into from Dec 7, 2023
Merged

Fixing Two Minor CMake Bugs #2412

merged 2 commits into from Dec 7, 2023

Conversation

LeStarch
Copy link
Collaborator

@LeStarch LeStarch commented Dec 7, 2023

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

There are two minor CMake bugs:

  1. A set of variables was cleared rather than unset
  2. CMAKE_SYSTEM_NAME was used instead of FPRIME_PLATFORM after creation of that variable

Rationale

Bug fixes!

@LeStarch
Copy link
Collaborator Author

LeStarch commented Dec 7, 2023

Fixes #2413 and #2414

@LeStarch LeStarch merged commit 2604f85 into nasa:devel Dec 7, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-bc thomas-bc thomas-bc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LeStarch @thomas-bc