Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI on release branches #2417

Merged
merged 4 commits into from Dec 8, 2023
Merged

Add CI on release branches #2417

merged 4 commits into from Dec 8, 2023

Conversation

thomas-bc
Copy link
Collaborator

@thomas-bc thomas-bc commented Dec 8, 2023 •
edited

Related Issue(s) #2411
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

  • Add release/* branches in CI, for both pushes and PR to those branches.
  • rename release/documentation branch docs/auto-documentation

Rationale

Easier release hotfix.

Future Work

  • double check that the bot pushes to docs/auto-documentation successfully
  • switch source branch for GH Pages build https://github.com/nasa/fprime/settings/pages
  • once things are confirmed to be working successfully, delete release/documentation branch

LeStarch
LeStarch approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Remember the GH pages settings after this is merged.

@thomas-bc thomas-bc merged commit af2a9cc into nasa:devel Dec 8, 2023
34 checks passed
@thomas-bc thomas-bc deleted the ci-releases branch December 8, 2023 21:07
@thomas-bc
Copy link
Collaborator Author

docs/auto-documentation has been successfully picked up by the workflow, and GitHub Pages were published from it! 🎉

Good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeStarch LeStarch LeStarch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomas-bc @LeStarch