Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FPP to v2.1.0a11 #2745

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Update FPP to v2.1.0a11 #2745

merged 5 commits into from
Jun 4, 2024

Conversation

bocchino
Copy link
Collaborator

  • Update FPP to v2.1.0a11
  • Make corresponding changes to client code

FPP Changes

@bocchino bocchino requested a review from LeStarch May 23, 2024 23:53
Fw/Dp/DpContainer.hpp Dismissed Show dismissed Hide dismissed
Svc/DpWriter/DpWriter.cpp Dismissed Show dismissed Hide dismissed
Svc/DpWriter/DpWriter.cpp Dismissed Show dismissed Hide dismissed
Fw/Types/ExternalString.hpp Dismissed Show dismissed Hide dismissed
Fw/Types/ExternalString.hpp Dismissed Show dismissed Hide dismissed
@bocchino
Copy link
Collaborator Author

CI is complaining because a link in a Markdown file in the cmake docs is unavailable. The issue is unrelated to this PR.

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, otherwise looks great!

@@ -48,7 +51,7 @@ components:
These components produce data products and are typically mission-specific.
For example, they may produce science data.

1. Standard F Prime components for managing data products.
1. Standard F' components for managing data products.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should say not F'

Copy link
Collaborator Author

@bocchino bocchino May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I switched all instances of F' to F Prime, which I think is also acceptable. I have some questions about this, which we can resolve offline:

  1. What is that forward tick character, and how do I type it?
  2. Since forward tick seems to be a Unicode and not an ASCII character, is there a way to represent it in ASCII? Otherwise a Unicode text editor is required.
  3. Why are we using forward tick instead of prime ' when we write F'?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that if I were writing F' in Markdown as math I would write _F'_ which resolves to F'.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rob, I forwarded you an email from Jeff regarding guidance on spelling F Prime, or F´ for short with the prime symbol. This is what we are trying to adhere to. Both F´ or F Prime would work here.

On MacOS, the ´ character can be typed with Option+E.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Note that option-e generates an acute accent, not a prime symbol. There is a Unicode prime symbol, but it looks like it has no shortcut.

Single quote: F'
Prime symbol: Fʹ
Acute accent: F´

Fw/Types/test/ut/TypesTest.cpp Show resolved Hide resolved
@thomas-bc
Copy link
Collaborator

CI failure (markdown link not found) was fixed in #2746 and can safely be ignored

Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ready to merge when we are

@LeStarch LeStarch merged commit ca08ac9 into nasa:devel Jun 4, 2024
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants