Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will introduce rechucking during netcdf-to-zarr step.
The destination chunk size will be the multiplier of the original chunk size closest to 3000, or 3000 if the original chunk size is more than that.
If I don't explain it well, the formula is here from
convert.py
:Basically the idea is to make the destination chunk size to be "aligned" with the original chunk size (for performance reason), and 3000 is a number to avoid memory issue with the current netcdf-to-zarr container size.
We may not see too much performance improvement here, which will be the focus of the subsequent related stories.