New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HARMONY-388: Better consistency across Python repos #13
Conversation
Had to update faker to fix an issue with the github actions test failures in newer versions of Python: joke2k/faker#1439 |
README.md
Outdated
@@ -104,8 +104,8 @@ OPTIONAL -- Use with CAUTION: | |||
## Development Setup | |||
|
|||
Prerequisites: | |||
- Python 3.7+, ideally installed via a virtual environment such as `pyenv` | |||
- A local copy of the code | |||
- Python 3.7+, ideally installed via a virtual environment. We recommend using [pyenv](https://github.com/pyenv/pyenv) for managing multiple Python installations with different versions, in conjunction with a tool like [pyenv-virtualenv](https://github.com/pyenv/pyenv-virtualenv) or [Python's venv module](https://docs.python.org/3.7/library/venv.html) for creating an isolated virtual environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a recommendation - what about we just recommend venv built-in with Python rather than pyenv-virtualenv as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I didn't do that is because in a similar discussion a month or so ago, Patrick seemed to allude that we should not be too opinionated on which virtual environment tool is used, as long as there's a virtual environment. So here I was just trying to make the reader aware that they can use either. Also, in the description of this ticket, there was a line about trying to make things "more similar to harmony-py" -- which offers both venv and pyenv-virtualenv as viable tools. Although this alone doesn't make this repo identical to harmony-py, it seemed like a step in that direction, without being too disruptive. I'm ok with either route and think you have a good point -- just explaining my thought process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was mostly suggesting that to avoid complicating the end-user documentation, i.e. not mentioning or requiring one as a setup step. It feels akin to telling people which editor to use (though I think we may also do that in other docs...)
README.md
Outdated
@@ -104,12 +104,12 @@ OPTIONAL -- Use with CAUTION: | |||
## Development Setup | |||
|
|||
Prerequisites: | |||
- Python 3.7+, ideally installed via a virtual environment such as `pyenv` | |||
- Python 3.7+, ideally installed via a [virtual environment](https://github.com/nasa/harmony-service-example/blob/main/ENVHELP.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit (that I'm not even sure I'm right about): I'm on the fence about whether we should link across repos like this, but if we do, we should probably link in the direction of our dependency arrows. harmony-service-example depends on this repo, so the ENVHELP.md should go in this repo with harmony-service-example pointing to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it does feel kinda weird. I think I'll remove it.
What follows are the acceptance criteria and what I found or did to address them. (I also spoke with Chris prior to submitting this PR.)