Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MMT-3414: As a metadata user, I want to CRUD draft UMM-S records #1096

Merged
merged 185 commits into from
Jan 16, 2024
Merged

MMT-3414: As a metadata user, I want to CRUD draft UMM-S records #1096

merged 185 commits into from
Jan 16, 2024

Conversation

dmistry1
Copy link
Collaborator

No description provided.

macrouch and others added 30 commits November 7, 2023 12:46
@macrouch
MMT-3410: Adds routes for tool-drafts
b576adc
@macrouch
MMT-3410: Sets up apollo client to use local cmr token
8c9b002
@macrouch
MMT-3410: Adds draft preview page
a1676e7
@macrouch
MMT-3410: Added form and custom text widget
aafa483
@macrouch
MMT-3410: Navigate to form by clicking preview section title
b41df15
@macrouch
MMT-3410: Fixes fixes the preview page field level links
0e021ca
MMT-3410: Added widgets and templates
f35db7e 
Added:
CustomSelect
CustomTextarea
CustomDateTime
CustomArrayField
@htranho
MMT-3410: Convert BoundingRechtangleField
7cd4dd7
@htranho
MMT-3410: Fix scss file, typo in file name BoundingRechtangleField
e1c4b36
@htranho
MMT-3410: Add BoundingRectangleField
5f620d3
@mandyparson
MMT-3410: adding CustomRadioWidget
5e82267
@mandyparson
Merge branch 'MMT-3410' of https://github.com/nasa/mmt into MMT-3410
97017dc
@mandyparson
MMT-3410: fixing conflicts
2035104
MMT-3410: Moved StreetAddressField to use Functional Components.
7aeee85
Merge branch 'MMT-3410' of https://github.com/nasa/mmt into MMT-3410
9df2ba1
@macrouch
MMT-3410: Store active draft in context
ab6fdbd
MMT-3410: Added StreetAddress field to registered fields.
8e24057
Merge branch 'MMT-3410' of https://github.com/nasa/mmt into MMT-3410
e2ebb4e
MMT-3410: Fixed styles
3dc997a
MMT-3410: Added LayoutGridField support.
8debaae
@tle1989
MMT-3410: Change Class to functional component for CustomTitleField.jsx
1cbdcd4
@tle1989
MMT-3410: Remove the editor in functional component for CustomTitleFi…
5ffd039 
…eld.jsx
@tle1989
MMT-3410: Fix typo on MetadataForm.jsx
67575c4
@trevorlang
MMT-3410: Fixing display of form navigation
4ef762d
@htranho
MMT-3410: Add CustomCountrySelectWidget
4297585
@htranho
MMT-3410: Remove unused import
e8d4265
@htranho
MMT-3410: Update to use CustomCountrySelectWidget
cfc4a49
@mandyparson
MMT-3410: Adding CutomFieldTemplate
3d6c5bb
@mandyparson
Merge branch 'MMT-3410' of https://github.com/nasa/mmt into MMT-3410
6c95cff
@mandyparson
MMT-3410: Removing console.log
c029fe9
cgokey
cgokey requested changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@cgokey cgokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, you might be able to bump the code coverage up to 100 for MetadataForm, GridCheckboxPanel, and CustomSelectWidget, but I see why the others are where they are at.

trevorlang
trevorlang requested changes Jan 5, 2024
View reviewed changes
static/src/js/components/CustomSelectWidget/CustomSelectWidget.jsx Outdated Show resolved Hide resolved
static/src/js/components/CustomSelectWidget/CustomSelectWidget.jsx Outdated Show resolved Hide resolved
static/src/js/components/DraftPreview/DraftPreview.scss Outdated Show resolved Hide resolved
static/src/js/components/DraftPreview/DraftPreview.scss Outdated Show resolved Hide resolved
static/src/js/components/DraftPreview/DraftPreview.scss Outdated Show resolved Hide resolved
static/src/js/components/GridCheckboxPanel/__tests__/GridCheckboxPanel.test.js Show resolved Hide resolved
static/src/js/components/OneOfField/OneOfField.jsx Outdated Show resolved Hide resolved
static/src/js/operations/queries/getServiceDraft.js Outdated Show resolved Hide resolved
static/src/js/schemas/uiSchemas/services/serviceOrganizations.js Outdated Show resolved Hide resolved
@trevorlang trevorlang mentioned this pull request Jan 5, 2024
Merged
Deep Mistry and others added 3 commits January 12, 2024 16:00
MMT-3414: Addressed PR comments
73f9131
MMT-3414: refactored CustomSelect logic
cc5747a
@dmistry1 @macrouch
@htranho @mandyparson @tle1989 @trevorlang
MMT-3410: As a metadata user, I want to CRUD draft UMM-T records (#1101)
8f94b0e 
* MMT-3410: Adds routes for tool-drafts

* MMT-3410: Sets up apollo client to use local cmr token

* MMT-3410: Adds draft preview page

* MMT-3410: Added form and custom text widget

* MMT-3410: Navigate to form by clicking preview section title

* MMT-3410: Fixes fixes the preview page field level links

* MMT-3410: Added widgets and templates
Added:
CustomSelect
CustomTextarea
CustomDateTime
CustomArrayField

* MMT-3410: Convert BoundingRechtangleField

* MMT-3410: Fix scss file, typo in file name BoundingRechtangleField

* MMT-3410: Add BoundingRectangleField

* MMT-3410: adding CustomRadioWidget

* MMT-3410: fixing conflicts

* MMT-3410: Moved StreetAddressField to use Functional Components.

* MMT-3410: Store active draft in context

* MMT-3410: Added StreetAddress field to registered fields.

* MMT-3410: Fixed styles

* MMT-3410: Added LayoutGridField support.

* MMT-3410: Change Class to functional component for CustomTitleField.jsx

* MMT-3410: Remove the editor in functional component for CustomTitleField.jsx

* MMT-3410: Fix typo on MetadataForm.jsx

* MMT-3410: Fixing display of form navigation

* MMT-3410: Add CustomCountrySelectWidget

* MMT-3410: Remove unused import

* MMT-3410: Update to use CustomCountrySelectWidget

* MMT-3410: Adding CutomFieldTemplate

* MMT-3410: Removing console.log

* MMT-3410: Converse class to functional component CustomTitleFieldTemplate.jsx

* MMT-3410: Create folders for CustomTitleField, and CustomTitleFieldTemplate

* MMT-3410: Bug fixes to layout grid schema, street address field, and custom select widget.

* MMT-3410: Component clean up

* MMT-3410 Comments added, updated after feedback

* MMT-3410: Added JsonPreview, started on LayoutGridControlledField.

* MMT-3410: Add uiSchema prop types, and comments based on Matthew's feedback

* MMT-3410: Fix uiSchema Prop types based on Matthew's second feedback

* MMT-3410: Remove eslint exception in import

* MMT-3410: added CustomSelect keywords from CMR
Also fixed uiSchema propTypes

* MMT-3410: Fixed a bug in CustomSelect

* MMT-3410: Editing CRadioWidget and CFieldTemplate

* MMT-3410: Adding back in files

* MMT-3410: fixing radio buttons

* MMT-3410: Updates NagivationItemError

* MMT-3410: Updates to LayoutGridControlledField and CustomSelectBox

* MMT-3410: Updated comment.

* MMT-3410: More refactoring done on GridLayout

* MMT-3410: Add data-testid for CustomTitleField, it was missed when doing the conversion

* MMT-3410: Added a test, refactored widgets

* MMT-3410: Fixed issues with GridLayout

* MMT-3410: Fixed bad data

* MMT-3410: Added test

* MMT-3410: Added Keyword Picker

* MMT-3410: Added CustomMultiSelect

* MMT-3410: Addressed Matthew's comment
about select widget

* MMT-3410: Refactored KeywordPicker

* MMT-3410: Fixed test errors

* MMT-3410: Added jsDoc to the components and util

* MMT-3410: Fixed issue with CustomSelect propType

* MMT-3410: Added more tests

* MMT-3410: Updating bootstrap imports

* MMT-3410: Added jsDoc to all the components

* MMT-3410: Fixed issues with form disappearing when selecting a value from controlled field.

* MMT-3410: Fixed bug with StreetAddressField where it was not setting formData properly.

* MMT-3410: Adding tests

* MMT-3410: Add tests for clearFormData and convertToDottedNotation

* MMT-3410: Add tests to clearFormData

* MMT-3410: Added errorLogger Lambda

* MMT-3410: Tests for isRequired.js and remove extra export

* MMT-3410: Add test for getConceptTypeByDraftConceptId.js

* MMT-3410: Replace it() to test()

* MMT-3410: Change file name getFormData to getParentFormData

* MMT-3410: Add tests for removeEmpty.js

* MMT-3410: Rename getNextForm.js to getNextFormName.js

* MMT-3410: Add tests for shouldHideGetData.js

* MMT-3410: Cleaned up errorLogger and added tests

* MMT-3410: Add tests for shouldHideGetService.js

* MMT-3410: Change variable name from getData to setService for shouldHideGetService.js

* MMT-3410: Add test for getNextFormName.js

* MMT-3410: getAvailableKey and OnKeyChange Edits

* MMT-3410: Add tests for shouldFocusField.js

* MMT-3410: Add test for getFormSchema.js

* MMT-3410: Added tests for:
fetchCmrKeywords.js
parseCmrKeywords.js

* MMT-3410: Added test cases for getConfig.js

* MMT-3410: Building Manage and Drafts pages

* MMT-3410: Add tests, remove eslint-disable-next-line, remove named export, add more comments inside function for onPropertyChange.js

* MMT-3410: Fixing issue with draft preview

* MMT-3410: Changes GridField back to a class that extends ObjectField

* MMT-3410: Minor formatting changes

* MMT-3410: Linter fixes

* MMT-3410: Added tests for getKeywords, getParentFormData, parseCmrResponse (and moved traverse which is a helper function into parseCmrResponse).   Added mock data for related urls.

* MMT-3410: Fixed import and variable name.

* MMT-3410: Updated calling to CMR in KeywordPicker
Also updated test describe titles

* MMT-3410: Fixed the related-ur-ls in the URL

* MMT-3410: Added toLowerKebabCase util function

* MMT-3410: Follow describe/test blocks in the tests for removeEmpty.js and shouldFocusField.js

* MMT-3410: Polish test description

* MMT-3410: Restructure and add tests to createResponseFromKeywords

* MMT-3410: Updated traverse to pass in a node object and will now return the keywords.

* MMT-3410: Updated variable name to make it a bit more understandable.

* MMT-3410: Fixes validations

* MMT-3410: Added test cases for CustomTitleField

* MMT-3410: Refactors

* MMT-3410: Adding notifications

* MMT-3410: Fixing linting

* MMT-3410: renamed traverse to traverseCmrResponse

* MMT-3410: Added test cases for:
CustomArrayFieldTemplate
CustomTextWidget
CustomTitleField

* MMT-3410: Implments Cancel button, adds tests

* MMT-3410: Add test for BoundingRectangleField.jsx

* MMT-3410: Adds tests for reducers

* MMT-3410: Use user-event

* MMT-3410: Notifications tests

* MMT-3410: Added test for GridTitle

* MMT-3410: Add tests for CustomTitleFieldTemplate.jsx

* MMT-3410: Now checks props.

* MMT-3410: Fixed duplicate describe statement

* MMT-3410: Add test to CustomCountrySelectWidget

* MMT-3410: Rename directory 'CustomMultiSelect' to 'CustomMultiSelectWidget'

* MMT-3410 Add file CustomMultiSelectWidget.test.js

* MMT-3410: Renove unused file

* MMT-3410: Adds DraftPreview tests, adds retries to CMR calls

* MMT-3410: Add tests to CustomMultiSelectWidget

* MMT-3410: Adding tests for Radio Widget

* MMT-3410: Remove unused statement

* MMT-3410: Update imports

* MMT-3410: Added tests for KeywordPicker

* MMT-3410: MetadataForm tests

* MMT-3410: Add test to DraftList

* MMT-3410: Test cases for JsonPreview.jsx

* MMT-3410: Add test to StreetAddressField

* MMT-3410: Adds useControlledKeywords test

* MMT-3410: Added test for DateTime and
CustomFieldTemplate

* MMT-3410: Select widget tests

* MMT-3410: Added tests for GridField and GridRow

* MMT-3410: GridControlledField tests

* MMT-3410: Added GridCol test

* MMT-3410: Added tests for GridRow

* MMT-3410: Added tests for GridLayout

* MMT-3410: Add tests to Button.jsx

* MMT-3410: Form improvements and loading state

* MMT-3410: Add support for Download JSON.

* MMT-3410:  Resetting state variable if error occurs.

* MMT-3140: Added test for ObjectField.test.js

* MMT-3410: Changed from useQuery to useLazyQuery

* MMT-3410: Cleaned up and added createDownloadDraftParas

* MMT-3410: Added jsDoc for CustomFieldTemplate

* MMT-3410: Cleanup

* MMT-3410: More cleanup

* MMT-3410: Switch to lodash-es

* MMT-3410: Fixed tests for download json option.

* MMT-3410: Removed console.log

* MMT-3410: Added test for contructDownloadableFile

* MMT-3410: Forgot to include test.

* MMT-3410: accidently included unused import

* MMT:3410: More cleanup

* MMT-3410: Fixes tests

* MMT-3410: Updates readme

* MMT-3410: Removes console log

* MMT-3410: Use widget wrapper for country select, removes test ids

* MMT:3410: Fixes linting issue, updates comments to new ticket

* MMT-3410: Fixed all of the issues found during testing

* MMT-3410: Removed .scss file that was added

* MMT-3410: Fixed the preview bubbles

---------

Co-authored-by: Matthew Crouch <matthew@element84.com>
Co-authored-by: htranho <34069728+htranho@users.noreply.github.com>
Co-authored-by: Mandy Parson <amanda.parson@nasa.gov>
Co-authored-by: Christopher D. Gokey <chrisgokey@bitbucket.org>
Co-authored-by: tle1989 <tle1989@yahoo.com>
Co-authored-by: Trevor Lang <trevorlang@ymail.com>
@dmistry1 dmistry1 merged commit 8c9da0f into MMT-3390 Jan 16, 2024
5 checks passed
@dmistry1 dmistry1 deleted the MMT-3414 branch January 16, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandyparson mandyparson mandyparson left review comments

@trevorlang trevorlang trevorlang approved these changes

@cgokey cgokey cgokey approved these changes

@tle1989 tle1989 tle1989 approved these changes

@macrouch macrouch Awaiting requested review from macrouch

@htranho htranho Awaiting requested review from htranho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@dmistry1 @codecov-commenter @trevorlang @cgokey @tle1989 @mandyparson @macrouch @htranho