Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMT-3738: Remove provider context selection #1210

Merged
merged 4 commits into from
May 23, 2024
Merged

MMT-3738: Remove provider context selection #1210

merged 4 commits into from
May 23, 2024

Conversation

trevorlang
Copy link
Collaborator

Overview

What is the feature?

Removes the global provider context selection.

What is the Solution?

Remove the global provider context selection and add a modal to select providers before creating new concepts.

What areas of the application does this impact?

  • The menu was removed from the header
  • A modal was created to select providers when creating new concepts.
  • The index pages for each concept type was modified to remove the provider
    • Provider id was added as a column for types where it was not included
  • The provider id was added to the edit and show pages for the different types

Testing

Reproduction steps

  • Environment for testing: N/A
  • Collection to test with: N/A
  1. Confirm all concepts require the user to select a provider id
  2. Confirm the provider id is listed in all list pages
  3. Confirm the provider id is listed on all show pages
  4. Confirm the last provider the user selected is chosen by default when the modal opens

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2024

Codecov Report

Attention: Patch coverage is 98.31933% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.09%. Comparing base (3669991) to head (c35afec).

Files Patch % Lines
serverless/src/getTemplate/handler.js 90.00% 1 Missing ⚠️
...onents/ChooseProviderModal/ChooseProviderModal.jsx 94.44% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           MMT-3390    #1210      +/-   ##
============================================
+ Coverage     97.02%   97.09%   +0.07%     
============================================
  Files           331      333       +2     
  Lines          4773     4822      +49     
  Branches        972      980       +8     
============================================
+ Hits           4631     4682      +51     
- Misses          137      138       +1     
+ Partials          5        2       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trevorlang trevorlang merged commit 25dff8c into MMT-3390 May 23, 2024
5 of 7 checks passed
@trevorlang trevorlang deleted the MMT-3738 branch May 23, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants