-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MMT-3738: Remove provider context selection #1210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## MMT-3390 #1210 +/- ##
============================================
+ Coverage 97.02% 97.09% +0.07%
============================================
Files 331 333 +2
Lines 4773 4822 +49
Branches 972 980 +8
============================================
+ Hits 4631 4682 +51
- Misses 137 138 +1
+ Partials 5 2 -3 ☔ View full report in Codecov by Sentry. |
macrouch
reviewed
May 21, 2024
static/src/js/components/ChooseProviderModal/__tests__/ChooseProviderModal.test.jsx
Outdated
Show resolved
Hide resolved
static/src/js/components/ChooseProviderModal/__tests__/ChooseProviderModal.test.jsx
Outdated
Show resolved
Hide resolved
static/src/js/components/CustomModal/__tests__/CustomModal.test.jsx
Outdated
Show resolved
Hide resolved
trevorlang
commented
May 22, 2024
static/src/js/components/ChooseProviderModal/ChooseProviderModal.jsx
Outdated
Show resolved
Hide resolved
static/src/js/components/FormNavigation/__tests__/FormNavigation.test.jsx
Outdated
Show resolved
Hide resolved
macrouch
approved these changes
May 22, 2024
dmistry1
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
Removes the global provider context selection.
What is the Solution?
Remove the global provider context selection and add a modal to select providers before creating new concepts.
What areas of the application does this impact?
Testing
Reproduction steps
Checklist