-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Plot] Synchronize time conductor to plot zoom/pan state. #1261
Comments
@charlesh88 to design / talk specific gestures for this. May be separate gestures. Either @larkin or @akhenry working on implementation. |
Of course, what happens here is that setting the Time Conductor to the datetime bounds of a plot view then causes all other objects in view that are synced to the TC to change their bounds as well, just as if the user had directly manipulated the TC directly. When the TC is in Real-time mode, and the user has zoomed or panned in a plot, that plot "breaks off" from the TC and real-time updates - effectively, the plot is in fixed time mode while the TC and everything else keeps on keeping on in RT mode. If the user is allowed to sync the TC from that plot while the TC is in RT mode, what should happen? If we allow this action, then it seems to me that we have to exit real-time mode. I'd suggest that throwing up a warning dialog informing the user that this action will exit RT mode, with Ok and Cancel would be sufficient. Another option is to not allow the TC-sync-from-plot gesture when in RT mode. I don't like this because it seems like an undue restriction, and might confuse users as to why the functionality isn't available. Charles putting this question to Mark via email. |
With regard to separate gestures, here's how that might break down:
Number 1 above is the simplest, and gets my vote for an initial implementation. 2 might also be desirable. 3 doesn't make sense unless I've missed something. @larkin @VWoeltjen @akhenry What do you think? What are VISTA use cases that might pertain here? I'll also put this to Mark via email. |
This summarizes my thoughts pretty well. There are plausible use cases for 2 but this may not be the only way to satisfy them (to recenter seems like something I'd be inclined to do using the time-of-interest instead of plot bounds), so I'd wait for a user request to see what form that takes. |
Mark's response to the question posed re. what do when in RT mode:
|
Ok, having left this open for a bit for comments, I say let's move ahead. At this point, the consensus is this:
Updated UI published here starting on page 57. Reassigning to @akhenry for implementation. Note that there are some small design changes to the local control buttons that I'll take care of; let's coordinate on where and how to do this. |
Bumping due to new Plot, and further discussions necessary around zoom. |
revised as a plot feature (not a conductor feature). |
Is there any progress on this feature? Would be super useful! Especially with stacked plots. |
The design attached here appears old. @charlesh88 @tiffanyatruong Please attach new designs for this feature. |
Testing instructions: Pan/zoom the plot again (now in fixed timespan mode) |
Verified fixed Testathon 6/4/2021 |
1 similar comment
Verified fixed Testathon 6/4/2021 |
Verified Fixed. |
It should be possible via a button or gesture to set the bounds of the time conductor based on a plot's current pan/zoom state.
The text was updated successfully, but these errors were encountered: