Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Time Views] Basic prototype Time View that supports composition with imagery #2977

Closed
akhenry opened this issue Apr 28, 2020 · 10 comments · Fixed by #4114
Closed

[Time Views] Basic prototype Time View that supports composition with imagery #2977

akhenry opened this issue Apr 28, 2020 · 10 comments · Fixed by #4114

Comments

@akhenry
Copy link
Contributor

akhenry commented Apr 28, 2020

Define a basic view that shows a time axis, and supports composition of image objects. This should be consistent with early design sketches, which will be supplied separately. Images should be shown as thumbnails at appropriate points along the axis that reflect their timestamp.

Time axis should use D3, refer to Time Conductor for an example of this.

Success criteria:

  1. A new "Time View" that shows just an axis by default, where the start and end correspond to the current conductor start and end
  2. Dragging and dropping imagery into this view should result in image thumbnails being added along the timeline, with the position corresponding to image timestamps.
@charlesh88 charlesh88 changed the title [Time Views] Basic prototype time view that supports composition of images [Time Views] Basic prototype Time View that supports composition with imagery Apr 29, 2020
@charlesh88
Copy link
Contributor

@charlesh88 to work with @jvigliotta for design guidance.

@charlesh88 charlesh88 self-assigned this Apr 29, 2020
@jvigliotta
Copy link
Contributor

@charlesh88 nice! Do we want to set up a meeting to go over this?

@charlesh88
Copy link
Contributor

This functionality to be included in the new Timestrip View that @shefalijoshi is working on.

@charlesh88
Copy link
Contributor

Testing Notes

  1. Create or edit a Time Strip view.
  2. Add image telemetry to the composition.
  3. Verify that images are shown in the strip. Note that if imagery is close enough together in time, the actual imagery may not be displayed until rolled over with the mouse:

Images too close to be displayed in the strip:
image

Images far enough apart in time to be displayed:
image

  1. Hovering over an image should bring it to the fore:
    image

  2. Clicking a thumb in the strip should display the image in large view:

@charlesh88
Copy link
Contributor

Verified Testathon 9-20-21.

@shefalijoshi
Copy link
Contributor

Reopening as this doesn't work for non example imagery due to assumption of 'time' property

@charlesh88
Copy link
Contributor

charlesh88 commented Sep 28, 2021

Testathon 9-28-21, NOT fixed: clicking an image in the thumbstrip view should display the same image paused in large view, but instead always displays the latest image.
Also, if the time strip view is using it's own independent time context, use that in the preview.

image

image

Fixed in : #4280

@shefalijoshi
Copy link
Contributor

Issue found:
Hovering over an image in the time strip view continually requests an image from the server:
image

@jvigliotta
Copy link
Contributor

jvigliotta commented Sep 28, 2021

Issue:
Some lines seem to be behind the strip. Also, images aren't showing in small mode (if they're supposed to).

Screen Shot 2021-09-28 at 3 35 50 PM

Fixed in #4280

@charlesh88
Copy link
Contributor

Testathon 9-30-21: verified fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants