Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notebook] Users should not be limited to plain text in raw notebook entries; newlines should be honored. #3190

Closed
mudinthewater opened this issue Jul 14, 2020 · 4 comments
Assignees
Labels
type:enhancement verified Tested or intentionally closed
Milestone

Comments

@mudinthewater
Copy link

Notebook has potential to be used for operator logs if it has a fully functional html or otherwise text editor. Most of the features needed are already there, but it needs to accept at least the following features:

  1. Basic text editing features (font/headers/lists/bullets)
  2. Basic image features (not just from snapshots)
  3. Basic tabling features.

There are some other intricacies that would be nice such as the user that filed the note, but I believe that's outside of the MCT scope.

@charlesh88
Copy link
Contributor

charlesh88 commented Jul 16, 2020

Definitely agree on the requested features as above. @mudinthewater Ideas, thoughts on the following?

  • Is there currently an issue with newlines? In that, if you paste something with newline chars, the entry ignores them? If so, we should fix.
  • Markdown with an embedded simple GUI (like the one here in GitHub perhaps?) seems like a good starting point, and there are 3rd party plugins we might leverage to support this. If this sounds like a good plan, any in particular that you like?
  • Imagery becomes a slightly more complex issue, mainly around storage. This is a general issue as well; using images in Display Layouts is problematic as we have no ability for users to upload and store images; they must use images already on a server that doesn't have issues with cross-domain requests.
  • We're planning to change the way the Enter key currently works because the current approach confused 100% of our testers in a recent user test. Rather than adding a newline/return, it will exit entry mode and save the entry, same as tabbing out. Users will be able to add line returns with Crtl + Enter.

@mudinthewater
Copy link
Author

I'll retest but I was attempting to put a list of commands exected to try to get a fake pass log in there but after saving it, the newlines appeared to have been disappeared.

I'm not picky about implementation - my vote is whichever is easiest!

CORs is such a pain - I'm assuming I can work around this by mucking around the JSON in couch like I usually do.

@scottbell
Copy link
Contributor

I think we've got this covered in #7084 and #7048. If we're missing some features beyond this, please feel free to reopen.

@akhenry
Copy link
Contributor

akhenry commented Mar 20, 2024

@akhenry akhenry added the verified Tested or intentionally closed label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement verified Tested or intentionally closed
Projects
None yet
Development

No branches or pull requests

6 participants