Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Condition Sets] Should not evaluate newer data that falls out of the time conductor bounds #3528

Closed
deeptailor opened this issue Nov 20, 2020 · 2 comments · Fixed by #3682
Closed

Comments

@deeptailor
Copy link
Member

Condition sets seem to be evaluating newer data that comes in, even if it falls out of the time conductor bounds.

Testing Instructions:

  1. Create a sine wave generator
  2. Create a condition set, and add sine wave generator
  3. Create a condition to evaluate sinewave generator - sine, to return true when value above 0.1
  4. Save.
  5. In real time mode, we should see the condition matching and not matching as the value changes.
  6. Switch to fixed time mode, use a start and end bound in the past.
  7. Verify the value of the sine wave generator does not change (it should use the latest value in the time bounds)
  8. Go back to condition set and observe the condition still behaves like its in real time mode.
@akhenry akhenry changed the title [Condition Sets] Keep evaluating newer data that falls out of the time conductor bounds [Condition Sets] Should not evaluate newer data that falls out of the time conductor bounds Jan 20, 2021
@josephml-nasa josephml-nasa mentioned this issue Feb 11, 2021
@davetsay
Copy link
Contributor

verified*

*was able to break condition set so that it wasn't evaluating and no new rows were being added to telemetry table view. switching to fixed time mode and then back to local time mode started the data back up.

@charlesh88
Copy link
Contributor

Verified fixed Testathon 3-3-21.

@akhenry akhenry removed the unverified label Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants