Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the browser back button in Open MCT #3588

Closed
nikhilmandlik opened this issue Dec 9, 2020 · 3 comments · Fixed by #3526
Closed

Fix the browser back button in Open MCT #3588

nikhilmandlik opened this issue Dec 9, 2020 · 3 comments · Fixed by #3526

Comments

@nikhilmandlik
Copy link
Contributor

Description:

Browser back button is not behaving as expected.

Testing instructions:

  1. navigate to different objects
  2. use 'back' and/or 'forward' buttons of browser history to navigate pages.
@Chaphasilor
Copy link

Just noticed this as well. You can never fully leave the page using the back button :P

@davetsay
Copy link
Contributor

davetsay commented Jun 2, 2021

Using the back and forward button navigates between views, but does not care about state. I think this needs to be addressed as you can be in edit mode, use the back button to get to a non-editable object, and still be in edit mode. Also, back should maybe be blocked while in edit mode so as to prevent loss of edits. Also noticed modals remain open. I start the remove notebook entry action, navigated to another object, then finished the the action to remove the notebook entry.

@jvigliotta
Copy link
Contributor

Separate issue to be created for issue @davetsay saw.

Verified Fixed - Testathon: 06/02/2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants