Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all * Listeners used by views #3688

Closed
deeptailor opened this issue Feb 16, 2021 · 1 comment
Closed

Remove all * Listeners used by views #3688

deeptailor opened this issue Feb 16, 2021 · 1 comment

Comments

@deeptailor
Copy link
Member

With the new Mutable DomainObject changes, we no longer need * listeners. In some cases, these listeners are causing issues since the mutable domainObject will keep itself updated.

We should remove all * Listeners that are being used to observe mutation changes on domainObjects passed into the view via the view API. Listeners may still be needed in cases where the view uses the Object API to retrieve a domainObject

@akhenry
Copy link
Contributor

akhenry commented Feb 25, 2021

Oh man, I knew I'd created an issue for this already but I couldn't find it when you created this. Thought I was going crazy :) This is a dupe of #3553

@akhenry akhenry closed this as completed Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants