Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compass rose sun jumps when loading new images #3706

Closed
charlesh88 opened this issue Feb 25, 2021 · 5 comments
Closed

Compass rose sun jumps when loading new images #3706

charlesh88 opened this issue Feb 25, 2021 · 5 comments
Assignees
@davetsay
Labels
severity:blocker type:bug

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Feb 25, 2021 •
edited

See during Testathon 2/25/21. When paging through images, the sun position often appears for a few milliseconds in one position, and then jumps to a new "actual" position.

image

We should put a v-if on the sun indicator and only show it if it has valid data and has been positioned.
@davetsay davetsay mentioned this issue Feb 25, 2021
Merged
@akhenry
Copy link
Contributor

akhenry commented Mar 1, 2021

Closed by #3713

@akhenry akhenry closed this as completed Mar 1, 2021
@akhenry
Copy link
Contributor

akhenry commented Mar 3, 2021

@davetsay Test instructions please

@charlesh88
Copy link
Contributor Author

Verified fixed Testathon 3-3-21.

@akhenry
Copy link
Contributor

akhenry commented Mar 3, 2021

Verified Fixed

@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon: 3/3/2021

@akhenry akhenry removed the unverified label Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davetsay davetsay

Labels
severity:blocker type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@charlesh88 @davetsay @akhenry @jvigliotta