Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Imagery Freshness] Need to have position freshness based on position, not orientation #3714

Closed
jvigliotta opened this issue Feb 26, 2021 · 3 comments · Fixed by #3723
Closed

Comments

@jvigliotta
Copy link
Contributor

Currently using rover orientation (heading, roll, pitch) for positional freshness, need to update to use actual rover position telemetry.

Need to add that to related telemetry and update the keys used for freshness for position and camera.

@akhenry
Copy link
Contributor

akhenry commented Mar 3, 2021

@jvigliotta Testing instructions please

@jvigliotta
Copy link
Contributor Author

Testing

  • on a server using relatedTelemetry, navigate to a cam image
  • verify there are freshness indicators (generally both pos and cam should be fresh for a bit after an ew image loads in)
  • you can also checkout the network tab to double check the correct related telemetry is being requested (ws too) when navigating to the image

@akhenry
Copy link
Contributor

akhenry commented Mar 4, 2021

Verified fixed.

@akhenry akhenry removed the unverified label Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants