Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Imagery] Remove roll and pitch as required keys for orientation #3745

Closed
jvigliotta opened this issue Mar 5, 2021 · 7 comments
Closed

[Imagery] Remove roll and pitch as required keys for orientation #3745

jvigliotta opened this issue Mar 5, 2021 · 7 comments
Assignees
@jvigliotta
Labels
type:enhancement

Comments

@jvigliotta
Copy link
Contributor

Roll and pitch will not be used in the final product. Need to remove them as any keys specified are required.

Testing

  • verify roll and pitch keys are removed from imagery config
  • make sure no calls to roll and pitch telemetry are being called in the network tab when viewing imagery
@jvigliotta jvigliotta self-assigned this Mar 5, 2021
@mariuszr
Copy link
Contributor

@jvigliotta Seems like it has been resolved in the merged PR #3744 during solving issue #3748

@mariuszr
Copy link
Contributor

mariuszr commented Apr 15, 2021 •
edited

@jvigliotta missed removing them from the Compass's unit test and the Imagery plugin unit test

@mariuszr mariuszr mentioned this issue Apr 15, 2021
Closed
@mariuszr
Copy link
Contributor

@davetsay @akhenry Please check and analyze my comments and PR related to the issue.

@jvigliotta
Copy link
Contributor Author

This was fixed in PR #3744

@mariuszr
Copy link
Contributor

mariuszr commented Aug 6, 2021

Hi @jvigliotta, please note that the PR #3817 completes the PR #3744 by removing the elements that were missed.

@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Aug 24, 2021 •
edited

@jvigliotta to verify and adding "testing" notes

@nikhilmandlik
Copy link
Contributor

Verified Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvigliotta jvigliotta

Labels
type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

3745 - [Imagery] Remove roll and pitch as required keys for orientation
5 participants
@nikhilmandlik @mariuszr @shefalijoshi @jvigliotta @unlikelyzero