Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement DeviceClassifier in vanilla JS #3788

Closed
akhenry opened this issue Apr 5, 2021 · 4 comments
Closed

Re-implement DeviceClassifier in vanilla JS #3788

akhenry opened this issue Apr 5, 2021 · 4 comments

Comments

@akhenry
Copy link
Contributor

akhenry commented Apr 5, 2021

The DeviceClassifier loads on startup and detects the user agent and device that is being used to render Open MCT. It then attaches some additional CSS classes to the DOM based on the platform that it is rendering on.

Right now this is implemented in Angular, and needs to be re-implemented in vanilla JS.

AgentService needs to be re-implemented as is implemented in AngularJS.

MCTDevice can be removed as it is not in use anymore.

@davetsay
Copy link
Contributor

Thanks for picking this one up, @mariuszr . Great work! Modified the issue description to include changes to AgentService and MCTDevice

@unlikelyzero unlikelyzero added this to To do in Remove AngularJS via automation Aug 24, 2021
@jvigliotta
Copy link
Contributor

@davetsay can we get testing instructions?

@davetsay
Copy link
Contributor

davetsay commented Sep 20, 2021

TESTING INSTRUCTIONS:

  • Navigate to Open MCT using various devices and see that site functions as intended. Some functionality may be limited on smaller resolution devices or devices using Safari as the browser.
  • When testing mobile devices, ensure toggling between landscape and portait mode works as intended (if using emulator can inspect element to see portrait or landscape classes)
  • When testing touch devices, ensure touch works

@davetsay
Copy link
Contributor

verified

@unlikelyzero unlikelyzero moved this from To do to Reviewer approved in Remove AngularJS Oct 5, 2021
@unlikelyzero unlikelyzero moved this from Reviewer approved to Done in Remove AngularJS Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
5 participants