Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon button labels are being clipped #3822

Closed
charlesh88 opened this issue Apr 20, 2021 · 7 comments · Fixed by #6036
Closed

Icon button labels are being clipped #3822

charlesh88 opened this issue Apr 20, 2021 · 7 comments · Fixed by #6036
Labels
bug:visual Visual problem. Not a functional issue severity:trivial type:bug
Projects
Bug Tracker
Milestone
Target:2.1.6

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Apr 20, 2021 •
edited

Icon buttons that have a text label are being clipped, sometimes hiding the characters descenders. Look at the bottom of the "g" (text changed to illustrate the effect):

Screen Shot 2021-04-20 at 2 39 26 PM

Adding padding: 1px 0 to the label fixes the problem:

Screen Shot 2021-04-20 at 2 39 59 PM
@charlesh88 charlesh88 self-assigned this Apr 20, 2021
@imrishabh18
Copy link

@charlesh88 Is this issue been fixed? Or I can do it if not done yet 😃

@unlikelyzero unlikelyzero added the bug:visual Visual problem. Not a functional issue label Jun 2, 2021
@unlikelyzero unlikelyzero added this to Needs triage in Bug Tracker Jun 3, 2021
@unlikelyzero unlikelyzero moved this from Needs triage to Current Testathon in Bug Tracker Jun 3, 2021
@unlikelyzero unlikelyzero moved this from Current Sprint to Will Do in Bug Tracker Jun 4, 2021
@jvigliotta
Copy link
Contributor

@charlesh88 thoughts?

@taintedbones taintedbones mentioned this issue Dec 3, 2022
Merged
15 tasks
@ozyx
Copy link
Member

ozyx commented Dec 6, 2022

Testing Instructions

  1. In chrome devtools, edit the label text of an icon button to include characters with descenders (such as what's been done above, Snapshot -> Snagshot)
  2. Verify that the descenders are not cutoff

@unlikelyzero unlikelyzero added this to the Target:2.1.6 milestone Dec 28, 2022
Bug Tracker automation moved this from Will Do to Done Jan 20, 2023
@michaelrogers
Copy link
Contributor

michaelrogers commented Jan 24, 2023 •
edited

Fix verified locally during testathon 2022-01-24. Snagshot fully displays its non-clipped descenders.

@rukmini-bose
Copy link
Contributor

Testathon Verified 1/24/2023

@jvigliotta
Copy link
Contributor

Screen Shot 2023-01-24 at 3 09 57 PM
Verified Fixed: Testathon - 1/23/23

@charlesh88
Copy link
Contributor Author

Verified fixed Testathon 2023-01-24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:visual Visual problem. Not a functional issue severity:trivial type:bug
Projects
Bug Tracker
Done
Milestone
Target:2.1.6
Development

Successfully merging a pull request may close this issue.

[CLA on File] style: added padding to object & icon button labels taintedbones/openmct
7 participants
@charlesh88 @michaelrogers @ozyx @jvigliotta @unlikelyzero @imrishabh18 @rukmini-bose