Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "follow timer" action and indicator #3824

Closed
akhenry opened this issue Apr 21, 2021 · 7 comments · Fixed by #3855
Closed

Remove "follow timer" action and indicator #3824

akhenry opened this issue Apr 21, 2021 · 7 comments · Fixed by #3855

Comments

@akhenry
Copy link
Contributor

akhenry commented Apr 21, 2021

The "Follow Timer" action and indicator are leftovers from our legacy timeline view which has been deprecated for some time. These should be completely removed from our codebase, as they imply functionality that no longer exists.

This action and indicator are implemented in our legacy codebase, so you'll need to be sure to remove them from their relevant bundle as well.

@aimanafzal
Copy link

@akhenry I will get it done.

@jvigliotta
Copy link
Contributor

Hi @aimanafzal, if you haven't already, please follow the steps here #3821. We'll need this completed before you can contribute to the codebase. Thanks!

@aimanafzal
Copy link

Thanks @jvigliotta
Just signed a copy of the agreement and sent it to the email address mentioned in the document.

@akhenry
Copy link
Contributor Author

akhenry commented May 28, 2021

Testing Instructions

  1. Verify that the "Follow Timer" action is no longer available from the context menu for timer objects
  2. Verify that the follow timer indicator is no longer visible in the status bar.
    Screen Shot 2021-05-28 at 4 11 04 PM

@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon: 06/02/2021

@davetsay
Copy link
Contributor

davetsay commented Jun 2, 2021

verified

@charlesh88
Copy link
Contributor

Verified fixed Testathon 6/2/2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants