Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigation Tree] Revert/Refactor #3841

Closed
jvigliotta opened this issue Apr 26, 2021 · 3 comments · Fixed by #3886
Closed

[Navigation Tree] Revert/Refactor #3841

jvigliotta opened this issue Apr 26, 2021 · 3 comments · Fixed by #3886
Assignees

Comments

@jvigliotta
Copy link
Contributor

jvigliotta commented Apr 26, 2021

We need to combine the new tree refactor with the old tree design.

Key elements to include from both:

  • virtual scroll: only load the amount of tree items (plus a buffer) that will fit on screen (reducing DOM nodes, increasing performance)
  • target: locate/scroll to the currently viewed (object view) item in the navigation tree
  • ability to expand multiple sibling tree items at one time

Testing

Note: To show new tree collapse icon, you may need to 'disable cache' on browser and reload page 
Screen Shot 2021-06-02 at 10 28 44 AM

  • can open multiple sibling items in the navigation tree at one time (children as well)
  • can target (jump to item in nav tree) for any item (however far nested)
  • tree only has a minimal amount of nodes open at a time (roughly enough to fill the tree container (plus a buffer), use DOM inspector to verify
  • can collapse all tree items using new collapse button (next to sync)
  • can search
  • clicking an item, navigates you to the item
  • reflects items removed from composition using tree context menu and using elements pool in edit mode (display layouts, plots, etc)
  • remembers open folders on refresh
@davetsay
Copy link
Contributor

davetsay commented Jun 2, 2021

thanks for marking unverified @unlikelyzero

@nikhilmandlik
Copy link
Contributor

nikhilmandlik commented Jun 2, 2021

Verified Fixed. Looking good, Good Job @jvigliotta 👍

Not looking good, :(

  1. select a folder (eg: Test), have that folder collapse
  2. create new object (eg: SWG)
  3. click ok to save (SWG save into Test folder)
  4. Now you can see SWG
  5. But now if you click expand on parent we see 2 SWG

@charlesh88
Copy link
Contributor

Verified NOT fixed, seeing some erroneous behavior:

  • This is occurring when an object without a valid parent has been used as a sync target in the tree:
  • Clicking the sync tree button wasn't working;
  • After scrolling the tree and then mouse up, the tree would scroll itself back up;

Tree refactor rubber band scrolling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants