Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Ok" is not OK #3849

Closed
charlesh88 opened this issue Apr 30, 2021 · 2 comments · Fixed by #3850
Closed

"Ok" is not OK #3849

charlesh88 opened this issue Apr 30, 2021 · 2 comments · Fixed by #3850
Labels
type:bug

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Apr 30, 2021 •
edited

"OK" should be normalized as all caps in dialogs across the app.

Testing Notes

Invoke a variety of modal dialogs across the app, such as removing an object, and verify that the "OK" button displays that text in all caps.
@charlesh88 charlesh88 self-assigned this Apr 30, 2021
@charlesh88 charlesh88 mentioned this issue Apr 30, 2021
Merged
@charlesh88 charlesh88 changed the title "Ok" is not "OK" "Ok" is not OK Apr 30, 2021
@charlesh88
Copy link
Contributor Author

Verified NOT fixed Testathon 6/2/2021: "Ok" is still displaying in the Snapshot remove dialog as mixed case.

image

@davetsay
Copy link
Contributor

davetsay commented Jun 2, 2021

Instance of Ok not OK also in remove entry in Notebook.
image

Using code search I see instances in removeDialog.js, Notebook.vue and ImportAsJSONAction.js

@nikhilmandlik nikhilmandlik pinned this issue Jun 9, 2021
@nikhilmandlik nikhilmandlik unpinned this issue Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Normalize "OK" to uppercase in all dialogs; nasa/openmct
5 participants
@charlesh88 @davetsay @shefalijoshi @jvigliotta @unlikelyzero