Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial automated Lighthouse testing to CI #3939

Closed
unlikelyzero opened this issue Jun 14, 2021 · 2 comments · Fixed by #3906 or #3957
Closed

Add initial automated Lighthouse testing to CI #3939

unlikelyzero opened this issue Jun 14, 2021 · 2 comments · Fixed by #3906 or #3957
Labels
type:maintenance tests, chores, or project maintenance

Comments

@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Jun 14, 2021

https://github.com/GoogleChrome/lighthouse-ci automates the configuration, collection and assertions for Google Chrome's lighthouse tool.

This means our team can:

  1. Keep track of performance audit change over time to track regressions
  2. Ensure that the parent projects which source Open MCT are also performant or following best practices

Initial Implementation:
The lighthouse CI project provides guidance on how to get started with automated lighthouse ci checks here

  • In our first implementation, this is designed to be run ad-hoc as the tool is hardened as a Github Workflows
  • 'warn' instead of 'error' on most assertions
  • Set examples of how to warn or error on given thresholds
  • Only collect best-practices and performance measurements and assert against them

Further iteration:

  • Determine how to load test data to execute against different contexts like plot performance
  • Run more than ad-hoc. This can be configured to be nightly, per merge, or even block commits
  • Custom Performance Marks
  • Generalize config so that this can run on all parent projects like https://github.com/akhenry/openmct-yamcs
  • Set up internal lighthouse CI sever to run and compare previous releases to project how the performance has improved over time

Testing Notes:

Run Github Action Workflow on 'master'
Run Github Action Workflow on random branch

@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Jun 14, 2021
@unlikelyzero unlikelyzero changed the title Add automated Lighthouse testing Add initial automated Lighthouse testing to CI Jun 14, 2021
@unlikelyzero unlikelyzero reopened this Jun 24, 2021
@unlikelyzero
Copy link
Collaborator Author

Re-opening to fix in #3957

@shefalijoshi
Copy link
Contributor

Verified - Action runs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
2 participants