Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Timestrip] Zoom and pan are incorrectly disabled for Plot object views contained within a Timestrip #3974

Closed
charlesh88 opened this issue Jun 25, 2021 · 3 comments · Fixed by #4272

Comments

@charlesh88
Copy link
Contributor

Reproduce

  1. Create a Timestrip and add numeric telemetry that view as plots. Save the Timestrip.
  2. In the tree, expand the Timestrip and navigate to one of the telemetry points. The main view should show a plot view.
  3. Mouseover the plot and observe: no zoom buttons are displayed.
  4. Try to zoom via dragging a marquee or by using the mousewheel, observe: nothing happens.

This is a side effect of the desire to disable zoom and pan while viewing the Timestrip itself, but has had an undesired effect of suppressing those features for the Timestrip's children's views themselves.

Solution: use CSS pointer-events: none applied to the plot view's .gl-plot-display-area element when within a Timestrip.

@charlesh88 charlesh88 self-assigned this Jun 25, 2021
@shefalijoshi
Copy link
Contributor

shefalijoshi commented Jun 25, 2021

We're disabling gesture controls right now by looking at the objectPath and checking if there is a time strip in that path.
This may not be the best way to disable controls.
https://github.com/nasa/openmct/blob/master/src/plugins/plot/PlotViewProvider.js#L43

The fix might be to check that the current view is a time strip view instead.

@shefalijoshi shefalijoshi self-assigned this Jun 25, 2021
@charlesh88
Copy link
Contributor Author

@shefalijoshi Let me know how you want to proceed. The CSS solution will work I think, but may not be the best practice.

@unlikelyzero unlikelyzero added this to Needs triage in Bug Tracker via automation Jul 7, 2021
Bug Tracker automation moved this from Needs triage to Done Sep 30, 2021
@nikhilmandlik nikhilmandlik linked a pull request Sep 30, 2021 that will close this issue
8 tasks
@nikhilmandlik
Copy link
Contributor

Verified Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

4 participants